First commit of Wanderland - An Alice-layout keyboard #12516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
Add new line at end of file
Add new line at end of file
Add new line at end of file
Add new line at end of file
|
@fauxpark Hi Ryan, good day to you. Could you please take a look at this PR? Thank you in advance! |
fauxpark
requested changes
Apr 19, 2021
Remove "key_count" of LAYOUT_alice, from info.json Co-authored-by: Ryan <[email protected]>
Remove "key_count" of LAYOUT_alice_split_bs, from info.json Co-authored-by: Ryan <[email protected]>
Remove `keymaps/default/rules.mk` This file enables nothing, so can be removed.
Remove 'BACKLIGHT_DRIVER = pwm', which is configured by default. Re-arrange lines. Co-authored-by: Ryan <[email protected]>
Remove `led_update_kb()` implementation, which is unnecessary. Note: the indicator leds are high active by default. Co-authored-by: Ryan <[email protected]>
Remove `OLED_DRIVER_ENABLE = no`. There is already a note in `readme.md` about no installation of OLED LCD.
|
Hi Ryan @fauxpark , I made changes to this PR, as your recommendations. I also re-built firmware and flash to PCB, it works fine. Thank you so much for your help. |
fauxpark
approved these changes
Apr 19, 2021
drashna
reviewed
Apr 19, 2021
Add instruction how to reset the PCB into bootloader mode.
drashna
approved these changes
Apr 19, 2021
|
Thanks! |
6 tasks
makenova
pushed a commit
to makenova/qmk_firmware
that referenced
this pull request
Apr 26, 2021
Co-authored-by: Ryan <[email protected]>
rizo
pushed a commit
to rizo/qmk_firmware
that referenced
this pull request
May 10, 2021
Co-authored-by: Ryan <[email protected]>
toddyamakawa
pushed a commit
to toddyamakawa/qmk_firmware
that referenced
this pull request
May 19, 2021
Co-authored-by: Ryan <[email protected]>
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist