Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LED matrix and 2 layouts to hub20 #12505

Merged
merged 15 commits into from
Jun 20, 2021
Merged

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Apr 7, 2021

Description

Types of Changes

Adds 2 layouts to hub20
Changed rgb implementation from rgb light to a rgb matrix implementation.

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@peepeetee
Copy link
Contributor Author

@joshajohnson

@github-actions github-actions bot added the keymap label Apr 8, 2021
@peepeetee peepeetee changed the title Add numpad layouts to hub 20's info.json Add LED matrix and 2 layouts to hub20 Apr 8, 2021
@peepeetee peepeetee marked this pull request as draft April 8, 2021 03:00
@peepeetee
Copy link
Contributor Author

my rgb_matrix_map_row_column_to_led_kb implementation does not work, help

@peepeetee peepeetee marked this pull request as ready for review April 10, 2021 22:30
@drashna
Copy link
Member

drashna commented Apr 19, 2021

my rgb_matrix_map_row_column_to_led_kb implementation does not work, help

Your what?

@peepeetee
Copy link
Contributor Author

my rgb_matrix_map_row_column_to_led_kb implementation does not work, help

Your what?

rgb_matrix_map_row_column_to_led_kb
see keyboards/hub20/hub20.c :124

There's 3 keys on the board with 2 LEDs lighting them, and I want them to both light up in the LED effects. Checkout the messages linked below

see https://discord.com/channels/440868230475677696/473506116718952450/829572669115727903
and https://discord.com/channels/440868230475677696/473506116718952450/827648566168256572

I just commented my implementation out for now. The function is not documented, I'll probably work on documenting it when(or if) I figure it out

@drashna drashna requested a review from a team April 19, 2021 16:34
@stale
Copy link

stale bot commented Jun 3, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@peepeetee
Copy link
Contributor Author

What changes do I need to add?

keyboards/hub20/config.h Outdated Show resolved Hide resolved
@stale stale bot removed the awaiting changes label Jun 7, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
@drashna drashna requested a review from a team June 16, 2021 03:42
@drashna
Copy link
Member

drashna commented Jun 20, 2021

Thanks!

@drashna drashna merged commit dc39d90 into qmk:master Jun 20, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants