-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply the "NO_LIMITED_CONTROLLER_CONNECT" fix to atmega16u2 too (and … #12482
Apply the "NO_LIMITED_CONTROLLER_CONNECT" fix to atmega16u2 too (and … #12482
Conversation
…some other chips)
@SidneyBovet @M0les @jackhumbert Sorry for the ping. Any chance you could test this change with the above mentioned keyboards? I am pinging you because you have contributed to the above mentioned two keyboards in git history. |
Hey there, happy to help. I tried with my Great change as far as I am concerned! |
Thanks! I have updated the PR description to say it's now tested. @qmk/collaborators please review |
Co-authored-by: Ryan <[email protected]>
Thanks! |
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Description
I noticed while browsing code, that this modifier macro is applied only to the atmega32u2 mcu,
however looking at LUFA code it is something that applies to all Series 2 and Xmega AVRs too.
Looking at LUFA code this macro is tested for in very few places, and looks like it is only tested
in the case of MCUs for which it matters, so it's okay for it to be indiscriminately defined.
So looking at what keyboards we have I found we have two atmega16u2 keyboards in our keyboards folder:
These keyboards are most likely benefited by this change.
Tested by @SidneyBovet
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Tested by @SidneyBovet