Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the "NO_LIMITED_CONTROLLER_CONNECT" fix to atmega16u2 too (and … #12482

Merged

Conversation

purdeaandrei
Copy link
Contributor

@purdeaandrei purdeaandrei commented Apr 4, 2021

Description

I noticed while browsing code, that this modifier macro is applied only to the atmega32u2 mcu,
however looking at LUFA code it is something that applies to all Series 2 and Xmega AVRs too.

Looking at LUFA code this macro is tested for in very few places, and looks like it is only tested
in the case of MCUs for which it matters, so it's okay for it to be indiscriminately defined.

So looking at what keyboards we have I found we have two atmega16u2 keyboards in our keyboards folder:

  • sixkeyboard
  • xd004/v1

These keyboards are most likely benefited by this change.

Tested by @SidneyBovet

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).
    Tested by @SidneyBovet

@github-actions github-actions bot added the core label Apr 4, 2021
@purdeaandrei
Copy link
Contributor Author

@SidneyBovet @M0les @jackhumbert Sorry for the ping. Any chance you could test this change with the above mentioned keyboards? I am pinging you because you have contributed to the above mentioned two keyboards in git history.

@SidneyBovet
Copy link
Contributor

Hey there, happy to help. I tried with my xd004/v1 and it does work as highlighted in tmk/tmk_keyboard#361, i.e. it could wake up my Windows 10 from sleep (and I tested without the changes, it does not). Needless to say it flashed and behaved just fine.

Great change as far as I am concerned!

@purdeaandrei
Copy link
Contributor Author

Hey there, happy to help. I tried with my xd004/v1 and it does work as highlighted in tmk/tmk_keyboard#361, i.e. it could wake up my Windows 10 from sleep (and I tested without the changes, it does not). Needless to say it flashed and behaved just fine.

Great change as far as I am concerned!

Thanks! I have updated the PR description to say it's now tested.

@qmk/collaborators please review

tmk_core/protocol/lufa.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team April 19, 2021 08:14
@drashna
Copy link
Member

drashna commented Apr 19, 2021

Thanks!

@drashna drashna merged commit dcb8407 into qmk:develop Apr 19, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants