Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utf-8 encoding to an open() call #12388

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Add utf-8 encoding to an open() call #12388

merged 1 commit into from
Mar 27, 2021

Conversation

skullydazed
Copy link
Member

@skullydazed skullydazed commented Mar 26, 2021 •
edited
Loading

Description

This was missed in a recent PR.

Types of Changes

  • Core
  • Bugfix

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Mar 26, 2021
@skullydazed skullydazed marked this pull request as ready for review March 26, 2021 14:51
@skullydazed skullydazed requested a review from a team March 26, 2021 14:51
@skullydazed skullydazed merged commit 5dc7951 into master Mar 27, 2021
@skullydazed skullydazed deleted the open_encoding branch March 27, 2021 15:55
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request Mar 28, 2021
@skullydazed @violet-fish
add utf-8 encoding to the open() call (qmk#12388)
dd6a238
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@skullydazed @mrtnee
add utf-8 encoding to the open() call (qmk#12388)
4906826
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
add utf-8 encoding to the open() call (qmk#12388)
bc50dca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skullydazed @fauxpark