Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keyboard jkdlab/binary_monkey #12374

Merged
merged 5 commits into from
Apr 19, 2021
Merged

Conversation

LDobac
Copy link

@LDobac LDobac commented Mar 25, 2021

Hi! We made 3-Key macropad keyboard inspired by monkey!
It keyboard consists of 1, 0 and Enter Keys.
And We also made funny keymap called Ascii keymap. If press 0 and 1, it will record by binary and press enter it represent to ascii code.

Description

This keyboard 3-Key (1x3 matrix) macropad.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team April 3, 2021 04:07
keyboards/jkdlab/binary_monkey/readme.md Outdated Show resolved Hide resolved
keyboards/jkdlab/binary_monkey/readme.md Outdated Show resolved Hide resolved
keyboards/jkdlab/binary_monkey/rules.mk Outdated Show resolved Hide resolved
keyboards/jkdlab/binary_monkey/config.h Outdated Show resolved Hide resolved
Edit VENDOR_ID not used
@LDobac LDobac requested a review from drashna April 19, 2021 13:47
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drashna drashna merged commit 3990c0f into qmk:master Apr 19, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants