Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LED Matrix: Config functions #12361

Merged
merged 2 commits into from
Mar 28, 2021
Merged

LED Matrix: Config functions #12361

merged 2 commits into from
Mar 28, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 24, 2021 •
edited
Loading

Description

Introducing the helper/noeeprom/"" functions and lib8tion. Removed some commented out code that won't make it to the final version. BL_TOGG still does not function correctly yet, I hoped adding the task call to keyboard.c would fix it but I guess it's something in the existing code that I have yet to update.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 24, 2021 11:56
@fauxpark
Remove led_matrix_set_value
0a3627d 
It will be reintroduced later, as the equivalent of `rgb_matrix_set_color`
@fauxpark fauxpark merged commit 2ae38e9 into qmk:develop Mar 28, 2021
@fauxpark fauxpark deleted the led-matrix-config-functions branch March 28, 2021 06:59
@drashna drashna mentioned this pull request May 22, 2021
Closed
14 tasks
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@fauxpark @mrtnee
LED Matrix: Config functions (qmk#12361)
a5a1150
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
LED Matrix: Config functions (qmk#12361)
46e1bb3
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
LED Matrix: Config functions (qmk#12361)
0029b19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @tzarc