Adding afternoonlabs/oceanbreeze

[eithanshavit]

Description

Adding the new Ocean Breeze keyboard to Afternoon Labs

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[eithanshavit]

@fauxpark and @drashna, you both helped me review stuff before. Looking for some feedback. Thx!

[fauxpark]

Looks good, except the info.json needs to be redone without the rotation:

[eithanshavit]

@fauxpark, I should probably know this by now, but how are you testing these info.json files? Where's the render you're showing from?

[fauxpark]

You can preview info.json files by pressing Ctrl+Shift+I in the Configurator. It's also a good idea to verify the order matches the LAYOUT macro by turning on Fast Input and spamming a key.

[eithanshavit]

Thanks so much @fauxpark, I fixed the layout!

[eithanshavit]

@fauxpark, I think I finally got it :) Sorry for the delay. This is the order I think makes sense for this layout.

[fauxpark]

Per the layout macro:

I think it should be more like this:

[eithanshavit]

Thanks @fauxpark, is there a requirement that the macro and the info.json will follow the same order? I think that my proposal right now makes sense from the eyes of a user of this keyboard. For the macro, it makes sense for someone configuring this layout visually per the macro layout. For the info.json layout and configurator, the current proposal makes sense because configuring the thumb clusters is a different process than the alphas. And so I don't necessarily agree with your latest screenshot of having the upper thumb keys be in order of the lower alpha row.

[fauxpark]

The info.json determines what order the keys will be placed into the top half of the layout macro, and so they must exactly match. You've placed LT4 and RT1 in the lower alpha row of the layout macro, which is about where they are physically, thus they have to be placed there in the info.json. If you want your ordering, you'll need to shift those four thumb keys down a line in the layout macro.

[eithanshavit]

I see, ok I've updated it to behave like this.

[eithanshavit]

How's this looking now @fauxpark? Thanks for all the guidance

[fauxpark]

Looks pretty good, just a couple of minor cosmetic things.

[eithanshavit]

Looking for more reviews please 🙏

[drashna]

Thanks!