Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merc updates #12289

Merged
merged 12 commits into from
Apr 12, 2021
Merged

Merc updates #12289

merged 12 commits into from
Apr 12, 2021

Conversation

kylemccreery
Copy link
Contributor

Description

New changes to firmware inclusions made it slightly too bulky for this already tight firmware. Changing it to omit mousekeys by default for this keymap to prevent compilation size errors.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Apr 3, 2021

Just a heads up, enabling LTO may be a better option than disabling mousekeys.

@drashna drashna requested a review from a team April 3, 2021 01:43
@kylemccreery
Copy link
Contributor Author

@drashna That's probably fair feedback. I had a reason not to use that option and now I don't quite remember what that was. I do remember that it broke another option that I was trying to utilize, though it might not have been directly in this firmware.

I don't like doing something just because of a vague memory so I will test the LTO out tonight and make an update if it is working as intended.

@drashna
Copy link
Member

drashna commented Apr 5, 2021

Also does break action macros and action functions, but these are deprecated anyways, and should be replaced with the process_record_user type stuff anyways.

@kylemccreery
Copy link
Contributor Author

@drashna I can't find what it was breaking from the firmware that I was playing with, but I am still uneasy. I'm just going to let this one go through and push another one after I dig into it a little more. The Mercutio GB fulfillment orders will be delivered soon and I'd rather just have this small thing working as is and fix it once there is one on the books that works.

@Erovia Erovia merged commit 1a7a821 into qmk:master Apr 12, 2021
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
@kylemccreery kylemccreery deleted the merc_updates branch May 13, 2021 00:19
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants