-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merc updates #12289
Merc updates #12289
Conversation
…g old split source code. running into an issue now with col1 and row1 both not responding.
Just a heads up, enabling LTO may be a better option than disabling mousekeys. |
@drashna That's probably fair feedback. I had a reason not to use that option and now I don't quite remember what that was. I do remember that it broke another option that I was trying to utilize, though it might not have been directly in this firmware. I don't like doing something just because of a vague memory so I will test the LTO out tonight and make an update if it is working as intended. |
Also does break action macros and action functions, but these are deprecated anyways, and should be replaced with the process_record_user type stuff anyways. |
@drashna I can't find what it was breaking from the firmware that I was playing with, but I am still uneasy. I'm just going to let this one go through and push another one after I dig into it a little more. The Mercutio GB fulfillment orders will be delivered soon and I'd rather just have this small thing working as is and fix it once there is one on the books that works. |
Description
New changes to firmware inclusions made it slightly too bulky for this already tight firmware. Changing it to omit mousekeys by default for this keymap to prevent compilation size errors.
Types of Changes
Issues Fixed or Closed by This PR
Checklist