Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(keymaps): Changes to crkbd/keymaps/armand1m layout and README.md update #12252

Merged
merged 11 commits into from
Mar 25, 2021
Merged

feat(keymaps): Changes to crkbd/keymaps/armand1m layout and README.md update #12252

merged 11 commits into from
Mar 25, 2021

Conversation

armand1m
Copy link

@armand1m armand1m commented Mar 15, 2021 •
edited
Loading

Description

Changes to crkbd/keymaps/armand1m layout and README.md update.
Also adds JSON files for Keyboard Layout Editor.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Mar 17, 2021
View reviewed changes
keyboards/crkbd/keymaps/armand1m/crkbd-base-layer.json Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/armand1m/keymap.c Outdated Show resolved Hide resolved
@armand1m armand1m requested a review from drashna March 17, 2021 18:40
@armand1m armand1m requested a review from fauxpark March 18, 2021 16:39
@fauxpark fauxpark merged commit c59fb1b into qmk:master Mar 25, 2021
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request Mar 28, 2021
@armand1m @fauxpark @violet-fish
feat(keymaps): Changes to crkbd/keymaps/armand1m layout and README.md…
695a3cc 
… update (qmk#12252)

Co-authored-by: Ryan <[email protected]>
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@armand1m @fauxpark @mrtnee
feat(keymaps): Changes to crkbd/keymaps/armand1m layout and README.md…
2c15dc5 
… update (qmk#12252)

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armand1m @drashna @fauxpark