-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big quantum_keycodes cleanup #12249
Big quantum_keycodes cleanup #12249
Conversation
Also, I think the keycodes from via should be moved out of via.h, and into quantum_keycodes.h, at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this stay on master or go to develop?
I'm not really sure. On one hand, VIA remains unaffected by this, no keycode values it knows about are changed, and the ones that are it doesn't know about yet. Personally I would rather get this into master, as that allows VIA to start work on adding support for more keycodes faster. |
08ee19a
to
d631089
Compare
thanks! |
Description
Hoo boy.
As mentioned, this doesn't break VIA, but it does shuffle some values around, so perhaps this should go into develop instead?
Types of Changes
Issues Fixed or Closed by This PR
Checklist