Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big quantum_keycodes cleanup #12249

Merged
merged 3 commits into from
Apr 3, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 15, 2021

Description

Hoo boy.

  • Moved Swap Hands range to 0x5600, just to fill in that gap
  • Pulled range aliases (MIDI velocity min/max etc.) out of the enum and into defines at the end of the file
  • Annotated every keycode with its value in hex, up to the Sequencer keycodes - they still have yet to be made static, but at least they're at the end, for now
  • Removed all the ifdefs! And via_ensure_keycode.h doesn't complain! This does mean that everything guarded by an ifdef had to be moved to the end of the enum, though
  • Tweaked/added/improved some comments

As mentioned, this doesn't break VIA, but it does shuffle some values around, so perhaps this should go into develop instead?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 15, 2021 09:41
@drashna
Copy link
Member

drashna commented Mar 17, 2021

Also, I think the keycodes from via should be moved out of via.h, and into quantum_keycodes.h, at some point.

quantum/quantum_keycodes.h Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team March 21, 2021 10:45
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this stay on master or go to develop?

@fauxpark
Copy link
Member Author

fauxpark commented Mar 26, 2021

Should this stay on master or go to develop?

I'm not really sure. On one hand, VIA remains unaffected by this, no keycode values it knows about are changed, and the ones that are it doesn't know about yet.
On the other hand, this is a large enough change, breaking or no, that it could possibly be considered develop-worthy...

Personally I would rather get this into master, as that allows VIA to start work on adding support for more keycodes faster.

@fauxpark fauxpark changed the base branch from master to develop March 27, 2021 08:18
@fauxpark fauxpark force-pushed the quantum-keycodes-big-cleanup branch from 08ee19a to d631089 Compare March 27, 2021 08:18
@fauxpark fauxpark requested a review from a team March 27, 2021 08:19
@drashna drashna merged commit 8880e89 into qmk:develop Apr 3, 2021
@drashna
Copy link
Member

drashna commented Apr 3, 2021

thanks!

@fauxpark fauxpark deleted the quantum-keycodes-big-cleanup branch April 3, 2021 02:15
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants