Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing python dependencies to shell.nix #12051

Closed
wants to merge 1 commit into from
Closed

fix: Add missing python dependencies to shell.nix #12051

wants to merge 1 commit into from

Conversation

EdenEast
Copy link

@EdenEast EdenEast commented Feb 28, 2021

Description

The packages dotty-dict and jsonschemam were added to the
requirements.txt file but were not added to the shell.nix file.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The packages `dotty-dict` and `jsonschemam` were added to the
requirements.txt file but were not added to the shell.nix file.
@purcell
Copy link
Contributor

purcell commented Mar 5, 2021

See also #11181, which solves this problem and, I believe, introduces a much easier way to handle this in general.

@con-f-use
Copy link

#12295 is the better solution, since all the dependencies are now in a later version of nixpkgs, no need to pull them from pypi anymore.

I vote against merging this in favor of #12295.

@purcell
Copy link
Contributor

purcell commented Mar 22, 2021

#12295 is better than this, but I suggest from painful experience on python+nix projects that #11181 is the better choice for the long term, because it's unhelpful to be tied to the python library versions in nixpkgs: you will eventually end up adding overrides again, or being blocked on upstreaming and testing version changes in nixpkgs. The poetry/poetry2nix route does full dependency resolution, and can use newer pypi packages when desired or necessary, all without needing to update nixpkgs, and while retaining all the nix benefits.

@con-f-use
Copy link

Yes, I'm in favor of the poetry to nix route, I was just saying, if we wanted a working nix-shell right NOW, this PR should be merged and #11181 when everyone is happy.

@drashna
Copy link
Member

drashna commented Apr 3, 2021

This has some merge conflicts that need to be resolved, now

@purcell
Copy link
Contributor

purcell commented Apr 3, 2021

This has some merge conflicts that need to be resolved, now

I think that in any case, this one can be closed, since #12295 superseded it and has since been merged.

@EdenEast
Copy link
Author

EdenEast commented Apr 3, 2021

Since #12295 has been merged I will close this pr as she'll.nix has all it's dependencies.

@EdenEast EdenEast closed this Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shell.nix not up to date on latest python package dependencies
4 participants