Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tap_code_delay(code, delay) #11913

Merged
merged 2 commits into from
Feb 16, 2021
Merged

Add tap_code_delay(code, delay) #11913

merged 2 commits into from
Feb 16, 2021

Conversation

fauxpark
Copy link
Member

Description

Could be useful for encoders, if you don't want to define TAP_CODE_DELAY across the board.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team February 15, 2021 06:13
drashna
drashna reviewed Feb 15, 2021
View reviewed changes
docs/feature_macros.md Outdated Show resolved Hide resolved
@fauxpark @drashna
Update docs/feature_macros.md
9450a0d 
Co-authored-by: Drashna Jaelre <[email protected]>
@fauxpark fauxpark requested review from drashna and a team February 15, 2021 22:21
@fauxpark fauxpark merged commit 3345ce2 into qmk:develop Feb 16, 2021
@fauxpark fauxpark deleted the tap-code-delay branch February 16, 2021 20:26
@drashna
Copy link
Member

drashna commented Feb 17, 2021

This breaks AVR.

@fauxpark fauxpark mentioned this pull request Feb 17, 2021
Merged
14 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark @drashna
Add tap_code_delay(code, delay) (qmk#11913)
9254f8c 
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@zvecr zvecr zvecr approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
core documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @drashna @zvecr @spidey3