Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atlas alps/mx PCB addition #11884

Merged
merged 5 commits into from
Feb 24, 2021
Merged

Atlas alps/mx PCB addition #11884

merged 5 commits into from
Feb 24, 2021

Conversation

npspears
Copy link
Contributor

@npspears npspears commented Feb 13, 2021 •
edited
Loading

This PCB was created by me and has no connection to the OG Atlas PCB created by Gondo.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@npspears
Atlas alps/mx PCB addition
53c9152 
This PCB was created by me and has no connection to the OG Atlas PCB created by Gondo.
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Feb 13, 2021
@drashna drashna requested a review from a team February 19, 2021 04:18
fauxpark
fauxpark requested changes Feb 20, 2021
View reviewed changes
keyboards/cannonkeys/atlas_alps/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/readme.md Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/rules.mk Outdated Show resolved Hide resolved
@npspears
Copy link
Contributor Author

all suggestions to-do have been committed

drashna
drashna requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you can go to the "files changed" tab, and batch commit the suggestions.

keyboards/cannonkeys/atlas_alps/info.json Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/atlas_alps/rules.mk Show resolved Hide resolved
@npspears
Copy link
Contributor Author

Also, you can go to the "files changed" tab, and batch commit the suggestions.

thanks and done!

@npspears
Copy link
Contributor Author

not sure why one test didn't pass now

fauxpark
fauxpark approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis error is due to community layouts, can be safely ignored.

@drashna drashna merged commit 46f4422 into qmk:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npspears @drashna @fauxpark