Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add ISO layout for Durgod K320 #11872

Closed
wants to merge 1 commit into from
Closed

Conversation

nomis
Copy link

@nomis nomis commented Feb 12, 2021

Description

Add ISO layout for Durgod K320. This is mostly a copy of the ANSI layout but I've fixed the macro to match where the keys are.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nomis
Copy link
Author

nomis commented Feb 13, 2021

I've had to add a fix for the media keys because these are wrong in the existing ANSI layout.

Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that #11778 and #11885 have been merged, this PR has merge conflicts.
Can you please rebase, and push again?

@dkjer
Copy link

dkjer commented Feb 23, 2021

I believe #11778 covers these changes, at this point.

@nomis
Copy link
Author

nomis commented Feb 23, 2021

I believe #11778 covers these changes, at this point.

That still has the wrong Fn+F3 and Fn+F4 media keys.

@dkjer
Copy link

dkjer commented Feb 25, 2021

I believe #11778 covers these changes, at this point.

That still has the wrong Fn+F3 and Fn+F4 media keys.

Thanks for catching that. I updated #11978 with a fix for these media keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants