Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new handwired keyboard (Ergocheap) #11857

Merged
merged 27 commits into from
Apr 8, 2021
Merged

Add new handwired keyboard (Ergocheap) #11857

merged 27 commits into from
Apr 8, 2021

Conversation

xSteins
Copy link

@xSteins xSteins commented Feb 11, 2021 •
edited
Loading

Description

Finalized keyboard firmware

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Feb 13, 2021
View reviewed changes
keyboards/handwired/ergocheap/config.h Outdated Show resolved Hide resolved
keyboards/handwired/ergocheap/ergocheap.c Show resolved Hide resolved
keyboards/handwired/ergocheap/rules.mk Outdated Show resolved Hide resolved
@xSteins xSteins requested a review from drashna February 13, 2021 11:04
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Feb 15, 2021
@xSteins xSteins requested a review from drashna February 15, 2021 05:45
@xSteins
Copy link
Author

xSteins commented Feb 17, 2021

Can i get this keyboard merged? i have fixed those bugs :) @drashna

@drashna drashna requested a review from a team February 19, 2021 03:54
fauxpark
fauxpark requested changes Feb 20, 2021
View reviewed changes
keyboards/handwired/ergocheap/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/ergocheap/rules.mk Outdated Show resolved Hide resolved
@github-actions github-actions bot added the core label Feb 25, 2021
@xSteins xSteins requested a review from fauxpark March 10, 2021 14:23
fauxpark
fauxpark requested changes Mar 10, 2021
View reviewed changes
keyboards/handwired/ergocheap/mcuconf.h Outdated Show resolved Hide resolved
quantum/rgblight.h Outdated Show resolved Hide resolved
quantum/rgblight.c Outdated Show resolved Hide resolved
quantum/process_keycode/process_music.c Outdated Show resolved Hide resolved
keyboards/handwired/ergocheap/ergocheap.h Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the core label Mar 11, 2021
@Erovia
Copy link
Member

Erovia commented Apr 3, 2021

Hey @xSteins, can you look into updating the ChibiOS-related config files as fauxpark mentioned?

@xSteins
Copy link
Author

xSteins commented Apr 3, 2021

Hey @xSteins, can you look into updating the ChibiOS-related config files as fauxpark mentioned?

Sorry for late reply, i have updated the code. @Erovia

@Erovia Erovia requested review from fauxpark and a team April 3, 2021 18:55
fauxpark
fauxpark requested changes Apr 4, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chconf and halconf still need migrating.

@xSteins
Copy link
Author

xSteins commented Apr 4, 2021

chconf and halconf still need migrating.

done

@Erovia Erovia merged commit 75f8321 into qmk:master Apr 8, 2021
dfryer1193 pushed a commit to dfryer1193/qmk_firmware that referenced this pull request Apr 8, 2021
@xSteins @drashna
@fauxpark @dfryer1193
Add new handwired keyboard (Ergocheap) (qmk#11857)
3397454 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
makenova pushed a commit to makenova/qmk_firmware that referenced this pull request Apr 26, 2021
@xSteins @drashna
@fauxpark @makenova
Add new handwired keyboard (Ergocheap) (qmk#11857)
e1d202d 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
rizo pushed a commit to rizo/qmk_firmware that referenced this pull request May 10, 2021
@xSteins @drashna
@fauxpark @rizo
Add new handwired keyboard (Ergocheap) (qmk#11857)
374d1be 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
toddyamakawa pushed a commit to toddyamakawa/qmk_firmware that referenced this pull request May 19, 2021
@xSteins @drashna
@fauxpark @toddyamakawa
Add new handwired keyboard (Ergocheap) (qmk#11857)
6a6e1d1 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
@xSteins @drashna
@fauxpark @HokieGeek
Add new handwired keyboard (Ergocheap) (qmk#11857)
99f55ae 
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xSteins @Erovia @drashna @fauxpark