Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce memory allocator for ChibiOS builds with allocating debounce algorithms #11630

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Enforce memory allocator for ChibiOS builds with allocating debounce algorithms #11630

merged 1 commit into from
Jan 30, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jan 20, 2021

Description

Using one of the alternate debounce algorithms requires a memory allocator.
ChibiOS allows you to disable said memory allocator.

This puts some compile-time checks to enforce that the allocator has been enabled -- during testing with it set to FALSE, the keyboard would run and function correctly from a visible standpoint, but no keypresses would register. The fun part was, if the slave side had a firmware that had an allocator enabled, the master would still report keypresses on the slave, but not itself!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Add compile-time error if a board is configured without a memory allo…
0240344 
…cator, and someone attempts to use a debounce algo that calls malloc.
@tzarc tzarc requested a review from a team January 20, 2021 00:00
@github-actions github-actions bot added the core label Jan 20, 2021
noroadsleft
noroadsleft approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough.

@drashna drashna merged commit 4fe4087 into qmk:develop Jan 30, 2021
@tzarc tzarc deleted the malloc-safety-check branch March 2, 2021 05:00
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@tzarc
Enforce memory allocator for ChibiOS builds with allocating debounce …
d31fe52 
…algorithms (qmk#11630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzarc @drashna @noroadsleft