Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uni660 refactor #11526

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Uni660 refactor #11526

merged 1 commit into from
Jan 14, 2021

Conversation

fauxpark
Copy link
Member

Description

⚠ sirius/uni660: Falling back to searching for KEYMAP/LAYOUT macros.

#10792

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 12, 2021
@fauxpark fauxpark requested a review from a team January 12, 2021 15:54
@drashna drashna requested a review from a team January 12, 2021 21:00
@fauxpark
Copy link
Member Author

MD5s match after accounting for the product name change and addition of NO_ACTION_MACRO/NO_ACTION_FUNCTION 👍

@fauxpark fauxpark merged commit 72ca319 into qmk:master Jan 14, 2021
@fauxpark fauxpark deleted the uni660-refactor branch January 14, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna