-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dactyl manuform 5x6 2 5 keymap #11353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Also, any reason this is targeting develop, rather than master?
Nope, nothing in particular. Shall I switch the PR to master? |
Ideally, yeah. It's mostly only core PRs that need to target develop. Unless there is something that is only in develop, you should target master. |
528e79f
to
e6d0b11
Compare
Okay, I rebased the commits on master. |
Sorry about that, GitHub decided to delete the |
Could this be merged? |
Co-authored-by: Ryan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and fauxpark's request looks like it was addressed.
* feat(keymap): add DactylManuform w/ 2 extra keys and 5 thumb keys * fix(keymap): add missing readme * chore: add gpl2 license header * chore: add gpl2 license header * docs[dactyl_manuform_5x6_2_5]: reformat readme Co-authored-by: Ryan <[email protected]> Co-authored-by: Ryan <[email protected]>
* feat(keymap): add DactylManuform w/ 2 extra keys and 5 thumb keys * fix(keymap): add missing readme * chore: add gpl2 license header * chore: add gpl2 license header * docs[dactyl_manuform_5x6_2_5]: reformat readme Co-authored-by: Ryan <[email protected]> Co-authored-by: Ryan <[email protected]>
* feat(keymap): add DactylManuform w/ 2 extra keys and 5 thumb keys * fix(keymap): add missing readme * chore: add gpl2 license header * chore: add gpl2 license header * docs[dactyl_manuform_5x6_2_5]: reformat readme Co-authored-by: Ryan <[email protected]> Co-authored-by: Ryan <[email protected]>
* feat(keymap): add DactylManuform w/ 2 extra keys and 5 thumb keys * fix(keymap): add missing readme * chore: add gpl2 license header * chore: add gpl2 license header * docs[dactyl_manuform_5x6_2_5]: reformat readme Co-authored-by: Ryan <[email protected]> Co-authored-by: Ryan <[email protected]>
Description
Keymap for a DactylManuform with 5x6 layout, two additional keys (ctrl + alt) and five thumb keys.
Types of Changes
Checklist