-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Nix macOS build #11175
Fix Nix macOS build #11175
Conversation
@purcell thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this fix is appropriate and good: I can reproduce the error locally, and this resolves it.
Actually, hold off on merging -- just a couple more things to test first. |
Yeah, this is good to go -- thanks @pepyakin! I have a further fix to submit which fixes compilation on Big Sur, so expect a fresh PR soon. |
Just ran into this as well and was about to open a PR, but I'm glad I searched first :) Let me know if I can help test anything. |
Relatedly thinking it might be nice to set up a Cachix cache, and then have a build job which populates it. This way, us Nix users downstream can mostly avoid compiling |
P.S. See also #11181, which fixes the Nix shell for Big Sur users. |
Hey all, is there anything I can do to move this and #11181 forward? |
Description
For me, on macOS 10.15.7 running
make
would fail with errors about -iframework. This change fixes it. I assume that the name of the flag has been changed.I haven't checked this change on a linux platform. Would appreciate if somebody did.
Types of Changes
Issues Fixed or Closed by This PR
Checklist