Fix error handling in SPI master driver. #11122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This logic was copied from i2c_master; I don't know if that needs fixing as well. |
|
Not as far as I can see. The relevant lines are here and it seems to be ok on both counts ( I did notice though that |
dpapavas
force-pushed
the
spi_master_fix
branch
from
8c0300a to
9e34166
Compare
dpapavas
changed the title
fauxpark
approved these changes
Dec 5, 2020
tzarc
approved these changes
Dec 6, 2020
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
Co-authored-by: Dimitris Papavasiliou <[email protected]>
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 13, 2021
Co-authored-by: Dimitris Papavasiliou <[email protected]>
mgmanzella
pushed a commit
to mgmanzella/qmk_firmware
that referenced
this pull request
Feb 16, 2021
Co-authored-by: Dimitris Papavasiliou <[email protected]>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Co-authored-by: Dimitris Papavasiliou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues with the AVR SPI master driver, specifically in the error handling in
spi_receive. As it is, errors are only detected in the last byte and, more importantly, received zero bytes are ignored. The fix follows the simplest path of returning immediately in case of error, operating under the assumption that partial reads would be useless anyway.I have currently no easy way to test this as my keyboard doesn't use the
spi_masterdriver, or any of the QMK functionality that currently depends on it, so I have only verified that it compiles properly and that it looks like a reasonable fix. Sorry for that.Let me know if you like me to make any changes.
Types of Changes