Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the schema to eliminate custom code #11108

Merged
merged 5 commits into from
Jan 9, 2021
Merged

Use the schema to eliminate custom code #11108

merged 5 commits into from
Jan 9, 2021

Conversation

skullydazed
Copy link
Member

Description

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Dec 2, 2020
@skullydazed skullydazed marked this pull request as draft December 2, 2020 21:13
@skullydazed skullydazed mentioned this pull request Dec 16, 2020
Closed
13 tasks
@Erovia Erovia requested a review from a team December 30, 2020 19:16
@skullydazed skullydazed mentioned this pull request Jan 6, 2021
Closed
@skullydazed skullydazed force-pushed the json_schema branch 2 times, most recently from 0da286b to 68da9cd Compare January 6, 2021 18:30
Base automatically changed from json_schema to develop January 8, 2021 05:21
@skullydazed skullydazed marked this pull request as ready for review January 9, 2021 20:18
@skullydazed skullydazed requested review from a team and fauxpark January 9, 2021 20:18
@skullydazed skullydazed merged commit 962bc8d into develop Jan 9, 2021
@skullydazed skullydazed deleted the deep_copy branch January 9, 2021 21:34
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed @fauxpark
Use the schema to eliminate custom code (qmk#11108)
a21d7c6 
* use the schema to eliminate custom code

* Update docs/reference_info_json.md

Co-authored-by: Ryan <[email protected]>

* make flake8 happy

* bugfix

* do not overwrite make vars from json

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
cli qmk cli command documentation python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @Erovia @fauxpark