Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Axolstudio Yeti #11051

Merged
merged 17 commits into from
Dec 22, 2020
Merged

[Keyboard] Add Axolstudio Yeti #11051

merged 17 commits into from
Dec 22, 2020

Conversation

str-dst
Copy link
Contributor

@str-dst str-dst commented Nov 28, 2020

Description

Added Axolstudio Yeti keyboard. VIA keymap included.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 28, 2020
@str-dst str-dst mentioned this pull request Nov 28, 2020
6 tasks
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qmk info doesnt seem to like your Layout_Splitbs layout, as shown in the CI lint check

┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐┌──┐
│k1││k0││k0││k0││k0││k0││k0││k0││k0││k0││k0││k1││k1││k1││k1││k1││k3││k1││k1││k1││k2││k2││k2││k2││k2││k2││k2││k2││k2││k2││k3││k4││k3││k3││k3││k3││k3││k3││k3││k4││k4││k4││k4││k4││k3││k4││k5││k5││k5││k5││k5││k5││k5││k5││k5││k5││k6││k4││k6││k6││k6││k6││k6││k6││k6│
└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘└──┘

Any chance you could have a look at fixing this.

@zvecr zvecr requested a review from a team November 29, 2020 20:26
@str-dst
Copy link
Contributor Author

str-dst commented Nov 29, 2020

interesting. I'll see if I find anything

keyboards/axolstudio/yeti/yeti.h Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/rules.mk Outdated Show resolved Hide resolved
@str-dst str-dst requested review from zvecr and fauxpark December 1, 2020 15:31
keyboards/axolstudio/yeti/config.h Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary:

Renames the layouts as follows:

LAYOUT -> LAYOUT_alice
LAYOUT_all -> LAYOUT_alice_split_bs
LAYOUT_split_bs -> LAYOUT_alice_split_bs_full_rshift
LAYOUT_full_rshift -> LAYOUT_alice_full_rshift

Adds both current Alice community layouts to rules.mk


GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/axolstudio/yeti/yeti.h Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/yeti.h Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/yeti.h Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/yeti.h Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/info.json Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/axolstudio/yeti/rules.mk Show resolved Hide resolved
@noroadsleft noroadsleft changed the title Add Axolstudio Yeti [Keyboard] Add Axolstudio Yeti Dec 22, 2020
@noroadsleft noroadsleft merged commit 9453573 into qmk:master Dec 22, 2020
@noroadsleft
Copy link
Member

Thanks!

nblyumberg pushed a commit to nblyumberg/qmk_firmware that referenced this pull request Dec 31, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants