Add Via support to Plexus75 PCB #11027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added nasp before Plexus75 in PRODUCT to better follow Via naming convention
github-actions
bot
added
keyboard
keymap
via
changed KC_CTRL to KC_LCTL
drashna
requested changes
Nov 25, 2020
took out the manu repeat
npspears
commented
Nov 25, 2020
fauxpark
requested changes
Nov 26, 2020
npspears
commented
Nov 26, 2020
changed location of rules.mk for supporting Via
fauxpark
requested changes
Nov 26, 2020
Co-authored-by: Ryan <[email protected]>
fauxpark
requested changes
Nov 26, 2020
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
fauxpark
approved these changes
Nov 29, 2020
ridingqwerty
approved these changes
Dec 3, 2020
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
* Add Via keymap * Via Enable in Rules.mk * Update config.h added nasp before Plexus75 in PRODUCT to better follow Via naming convention * Update keymap.c changed KC_CTRL to KC_LCTL * Update config.h took out the manu repeat * Update rules.mk * Create rules.mk changed location of rules.mk for supporting Via * Apply suggestions from code review Co-authored-by: Ryan <[email protected]> * Update keyboards/plexus75/keymaps/via/rules.mk Co-authored-by: Ryan <[email protected]> * Apply suggestions from code review Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>
mgmanzella
pushed a commit
to mgmanzella/qmk_firmware
that referenced
this pull request
Feb 16, 2021
* Add Via keymap * Via Enable in Rules.mk * Update config.h added nasp before Plexus75 in PRODUCT to better follow Via naming convention * Update keymap.c changed KC_CTRL to KC_LCTL * Update config.h took out the manu repeat * Update rules.mk * Create rules.mk changed location of rules.mk for supporting Via * Apply suggestions from code review Co-authored-by: Ryan <[email protected]> * Update keyboards/plexus75/keymaps/via/rules.mk Co-authored-by: Ryan <[email protected]> * Apply suggestions from code review Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Issues Fixed or Closed by This PR
Checklist