Eek! keyboard firmware merge into QMK #11020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested changes
Nov 25, 2020
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
|
Hey @drashna ! Would you look over this one again? Thanks! |
drashna
reviewed
Nov 26, 2020
Co-authored-by: Drashna Jaelre <[email protected]>
I forgot about that! |
Co-authored-by: Drashna Jaelre <[email protected]>
fauxpark
requested changes
Nov 26, 2020
Co-authored-by: Ryan <[email protected]>
drashna
reviewed
Dec 4, 2020
drashna
reviewed
Dec 4, 2020
Co-authored-by: Drashna Jaelre <[email protected]>
|
Lint is unhappy that you don't have a readme in the silk up/down folders. |
@drashna Lol, I noticed that but, I was told to only include the silk_down.h /silk_up.h and the rules.mk file in the sub folders. I’ll add readme.md files in both. :-D |
|
@drashna They are added! |
drashna
approved these changes
Dec 6, 2020
|
@fauxpark I made the changes you requested along with making some other updates and improvements. When you have a chance would you review this again? |
fauxpark
requested changes
Dec 7, 2020
Co-authored-by: Ryan <[email protected]>
fauxpark
approved these changes
Dec 7, 2020
|
I had to correct a silly mistake in the layout in silk_up.h :-D |
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Erovia <[email protected]>
mgmanzella
pushed a commit
to mgmanzella/qmk_firmware
that referenced
this pull request
Feb 16, 2021
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: Erovia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to add the eek! keyboard to the master QMK repo.
Types of Changes
Issues Fixed or Closed by This PR
Checklist