Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added VIA keymap to YMDK bface keyboard #11002

Merged
merged 7 commits into from
Nov 30, 2020
Merged

Added VIA keymap to YMDK bface keyboard #11002

merged 7 commits into from
Nov 30, 2020

Conversation

Desp-Key
Copy link
Contributor

@Desp-Key Desp-Key commented Nov 22, 2020 •
edited
Loading

Description

Added keymap files to make YMDK bface VIA compatible.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Nov 22, 2020
zvecr
zvecr requested changes Nov 22, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/qmk/qmk_firmware/blob/master/keyboards/ymdk/bface/config.h#L20-L21 is also not unique and will need updating.

keyboards/ymdk/bface/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team November 22, 2020 00:33
@Desp-Key Desp-Key mentioned this pull request Nov 22, 2020
Closed
6 tasks
@Desp-Key
Update keymap.c
ce1a50b 
Changed LAYOUT_60_ansi to LAYOUT_all
@Desp-Key Desp-Key mentioned this pull request Nov 22, 2020
Merged
6 tasks
@Erovia Erovia requested review from a team, fauxpark, zvecr and Erovia November 28, 2020 19:03
@Erovia Erovia requested a review from a team November 28, 2020 19:03
fauxpark
fauxpark requested changes Nov 29, 2020
View reviewed changes
keyboards/ymdk/bface/config.h Outdated Show resolved Hide resolved
keyboards/ymdk/bface/config.h Outdated Show resolved Hide resolved
@Erovia Erovia merged commit 02fb0de into qmk:master Nov 30, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@Desp-Key @fauxpark @xgnxs
Added VIA keymap to YMDK bface keyboard (qmk#11002)
2ecea3c 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Desp-Key @Erovia @fauxpark @zvecr