Fix int wrapping for timer_expired macros #10996
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Nov 21, 2020
fauxpark
approved these changes
Nov 21, 2020
…sistency and clarity
XScorpion2
force-pushed
the
fix_timer_expired_macros
branch
from
76c8fd8 to
165bbd0
Compare
|
rebased & force push |
tzarc
approved these changes
Nov 30, 2020
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
…sistency and clarity (qmk#10996)
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 13, 2021
…sistency and clarity (qmk#10996)
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…sistency and clarity (qmk#10996)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small change to the timer_expired macros to fix cases on ARM where the int wrapping did not happen as expected, making the macros always return true. Additionally, switched from using a hex value for the half mark to the int max macros instead for clarity.
Types of Changes
Issues Fixed or Closed by This PR
Checklist