Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handwired/videowriter: oleg keymap update, via keymap #10984

Merged
merged 4 commits into from
Dec 6, 2020
Merged

handwired/videowriter: oleg keymap update, via keymap #10984

merged 4 commits into from
Dec 6, 2020

Conversation

DmNosachev
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 20, 2020
@DmNosachev DmNosachev changed the title oleg keymap update, via keymap handwired/videowriter: oleg keymap update, via keymap Nov 20, 2020
drashna
drashna requested changes Nov 25, 2020
View reviewed changes
keyboards/handwired/videowriter/config.h Outdated Show resolved Hide resolved
keyboards/handwired/videowriter/config.h Outdated Show resolved Hide resolved
keyboards/handwired/videowriter/keymaps/via/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 4, 2020 02:52
@drashna drashna merged commit b953a58 into qmk:master Dec 6, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@DmNosachev @drashna @xgnxs
handwired/videowriter: oleg keymap update, via keymap (qmk#10984)
c04c1f6 
* oleg keymap update, via keymap

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <[email protected]>

* via keymap use default bootloader

Co-authored-by: Drashna Jaelre <[email protected]>
mgmanzella pushed a commit to mgmanzella/qmk_firmware that referenced this pull request Feb 16, 2021
@DmNosachev @drashna @mgmanzella
handwired/videowriter: oleg keymap update, via keymap (qmk#10984)
6b107b9 
* oleg keymap update, via keymap

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <[email protected]>

* via keymap use default bootloader

Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmNosachev @drashna @fauxpark