-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rev2 & move rev1+rev2 to parent folder #10973
Conversation
Moved aplx6 to parent folder, renamed it to rev1 and added rev2
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, more of a general question, but why not aplyard
as the parent directory? You're using that as your Manufacturer name for the USB strings.
It's not wrong or anything, but it strikes me as unusual.
Also, as this moves the rev1 in a way that's not backwards compatible with the previous workflow (the |
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Co-authored-by: James Young <[email protected]>
Hey and thanks for a the suggestions. I simply use Aplx as a Category name for anything that has to do with a Keyboard. At first i tried it as " /aplyard/aplx6/rev2/... " and with the " qmk compile -kb aplyard/aplx6/rev2 -km default " i was getting an error which i couldnt figure out. Simply by changing the parent folder to aplx, it was compiling ok. |
hello, is there anything else you want me to do? made all the suggested changes. |
Moved aplx6 to parent folder, renamed it to rev1 and added rev2
rev2 has different keymap.c from rev1
Description
Aplx6 has a new rev and a new pcb with encoder & oled display support.
Made a parent folder named aplx, renamed aplx6 to rev and added rev2 folder and files.
Edited old rev1 readme.md to correct the make: example.
Sorry for any bad coding in advance :P
Types of Changes
Issues Fixed or Closed by This PR
Checklist