Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lasgweloth #10944

Merged
merged 8 commits into from
Dec 6, 2020
Merged

Lasgweloth #10944

merged 8 commits into from
Dec 6, 2020

Conversation

Gondolindrim
Copy link
Contributor

Lasgweloth v1.0 support

Description

Adds support for Lasgweloth v1.0 PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/acheron/lasgweloth/config.h Outdated Show resolved Hide resolved
keyboards/acheron/lasgweloth/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/acheron/lasgweloth/keymaps/xoxotus/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 17, 2020 02:45
keyboards/acheron/lasgweloth/rules.mk Outdated Show resolved Hide resolved
Gondolindrim and others added 3 commits December 2, 2020 15:58
Remove USB DESCRIPTION filed from config.h

Co-authored-by: Drashna Jaelre <[email protected]>
Remove unnecessary comment lines on rules.mk

Co-authored-by: Ryan <[email protected]>
@Gondolindrim
Copy link
Contributor Author

Changes applied, requesting re-review

Update readme.md
@drashna drashna merged commit dfeba3f into qmk:master Dec 6, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
* Initial Lasgweloth PCB support

* Fix column attribution

* Fix Col1 pin assignment

* New xoxotus layout and revised README

* Removed KC_NO definition

* Update keyboards/acheron/lasgweloth/config.h

Remove USB DESCRIPTION filed from config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/acheron/lasgweloth/rules.mk

Remove unnecessary comment lines on rules.mk

Co-authored-by: Ryan <[email protected]>

* Update readme.md

Update readme.md

Co-authored-by: Gondolindrim <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
mgmanzella pushed a commit to mgmanzella/qmk_firmware that referenced this pull request Feb 16, 2021
* Initial Lasgweloth PCB support

* Fix column attribution

* Fix Col1 pin assignment

* New xoxotus layout and revised README

* Removed KC_NO definition

* Update keyboards/acheron/lasgweloth/config.h

Remove USB DESCRIPTION filed from config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/acheron/lasgweloth/rules.mk

Remove unnecessary comment lines on rules.mk

Co-authored-by: Ryan <[email protected]>

* Update readme.md

Update readme.md

Co-authored-by: Gondolindrim <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants