Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for #define WS2812_RGB to support non-standard implementa… #10916

Closed
wants to merge 1 commit into from

Conversation

hvontres
Copy link

Add support for #define WS2812_RGB to support non-standard implementations like the Adafruit through hole leds that take RGB instead of GRB data.

Description

Added conditional compile to ws2812.c, ws2812_pwm.c and ws2812_spi.c to allow the green and red values to be swapped for non-standard leds.
Using a mixture is not supported and will require one type to have the color values assigned manually for correct operation.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • [ X] Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [X ] My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • [X ] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [X ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

…tions

like the Adafruit through hole leds that take RGB instead of GRB data.
@github-actions github-actions bot added the core label Nov 11, 2020
@hvontres hvontres marked this pull request as ready for review November 11, 2020 05:36
@fauxpark
Copy link
Member

Thanks for your contribution! This seems like it might be a duplicate of #10184 though.

@hvontres
Copy link
Author

You are correct. Feel free to ignore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants