Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add M4cs Keymap for dekunukem/duckyPad #10900

Merged
merged 23 commits into from
Nov 24, 2020
Merged

Add M4cs Keymap for dekunukem/duckyPad #10900

merged 23 commits into from
Nov 24, 2020

Conversation

M4cs
Copy link
Contributor

@M4cs M4cs commented Nov 9, 2020

This is a pull request containing my keymap for the duckyPad by @dekuNukem. Includes 3 layers w/ RGB settings as well.

Description

  • Adds keymap for duckypad
  • Adds dekunukem/duckypad folder

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Nov 16, 2020
View reviewed changes
keyboards/dekunukem/duckypad/config.h Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/config.h Show resolved Hide resolved
keyboards/dekunukem/duckypad/duckypad.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/duckypad.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/duckypad.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/duckypad.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/duckypad.h Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/m4cs/config.h Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/m4cs/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 16, 2020 21:19
@M4cs
Copy link
Contributor Author

M4cs commented Nov 17, 2020

Made changes based on your comments. All have been resolved.

@drashna drashna requested a review from a team November 17, 2020 05:05
fauxpark
fauxpark requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This board is missing a default keymap.

keyboards/dekunukem/duckypad/info.json Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/m4cs/rules.mk Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/rules.mk Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/readme.md Show resolved Hide resolved
@M4cs
Copy link
Contributor Author

M4cs commented Nov 18, 2020

@fauxpark I've made changes to resolve your comments. Thank you :)

zvecr
zvecr requested changes Nov 18, 2020
View reviewed changes
keyboards/dekunukem/duckypad/config.h Outdated Show resolved Hide resolved
@zvecr zvecr requested review from a team, fauxpark, zvecr and drashna November 18, 2020 21:39
zvecr
zvecr requested changes Nov 18, 2020
View reviewed changes
keyboards/dekunukem/duckypad/bootloader_defs.h Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Nov 19, 2020
View reviewed changes
keyboards/dekunukem/duckypad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/keymaps/m4cs/keymap.c Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/readme.md Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/readme.md Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/rules.mk Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/rules.mk Outdated Show resolved Hide resolved
@M4cs
Copy link
Contributor Author

M4cs commented Nov 19, 2020

@fauxpark Thanks for the suggested changes. I've gone ahead and fixed up my files.

fauxpark
fauxpark requested changes Nov 19, 2020
View reviewed changes
keyboards/dekunukem/duckypad/readme.md Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/rules.mk Outdated Show resolved Hide resolved
keyboards/dekunukem/duckypad/readme.md Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Nov 19, 2020
View reviewed changes
keyboards/dekunukem/duckypad/rules.mk Outdated Show resolved Hide resolved
@M4cs
Copy link
Contributor Author

M4cs commented Nov 20, 2020

Is my build failing due to other keyboards or is it mine?

@fauxpark
Copy link
Member

The former, but you can rebase this branch onto current master to make Travis build only this board.

@M4cs
Copy link
Contributor Author

M4cs commented Nov 21, 2020

The former, but you can rebase this branch onto current master to make Travis build only this board.

Thanks! Merged qmk upstream master into my branch, should fix the issue :)

@fauxpark fauxpark requested a review from a team November 21, 2020 23:52
@M4cs
Copy link
Contributor Author

M4cs commented Nov 23, 2020 •
edited
Loading

Fixed thanks @zvecr 👍🏼

@zvecr zvecr merged commit 66b5c5e into qmk:master Nov 24, 2020
@zvecr
Copy link
Member

zvecr commented Nov 24, 2020

Thanks!

xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@M4cs @frenchie0x4ff @xgnxs
Add M4cs Keymap for dekunukem/duckyPad (qmk#10900)
4733802 
* Add Keymap

* Fix Media Keys

* Add Keymap ASCII and Clean Up

* Add Readme

* Add GPL Headers, Clean Up Code Based on @drashna Suggestions

* Remove unnecessary include

* Add Layout for info.json and Readme.md

* Fix Layout for info.json

* Fix #endif Error

* Remove Tapping Term

* Add Default Keymap

* Add comments, fix readmes, clean up

* Fix README formatting

* Fix Timeout

* Fix I2C Rules

* Fix Comment Formatting, Multiline Breaks

* Add Sleep/Backlight Rules

* Clean Up README

* Clean Up Rules

* Fix Comments

* Add Pragmas

Co-authored-by: M4cs <[email protected]>
Co-authored-by: Max <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@M4cs @fauxpark @zvecr @drashna @frenchie0x4ff