Add rainkeeb keyboard #10875
Merged
Add rainkeeb keyboard #10875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for rainkeeb
ridingqwerty
requested changes
Nov 13, 2020
keyboards/rainkeeb/info.json
Outdated
Comment on lines
10
to
48
| {"label":"k00", "x":0, "y":0}, | ||
| {"label":"k01", "x":1, "y":0}, | ||
| {"label":"k02", "x":2, "y":0}, | ||
| {"label":"k03", "x":3, "y":0}, | ||
| {"label":"k04", "x":4, "y":0}, | ||
| {"label":"k05", "x":7, "y":0}, | ||
| {"label":"k06", "x":8, "y":0}, | ||
| {"label":"k07", "x":9, "y":0}, | ||
| {"label":"k08", "x":10, "y":0}, | ||
| {"label":"k09", "x":11, "y":0}, | ||
| {"label":"k10", "x":0, "y":1}, | ||
| {"label":"k11", "x":1, "y":1}, | ||
| {"label":"k12", "x":2, "y":1}, | ||
| {"label":"k13", "x":3, "y":1}, | ||
| {"label":"k14", "x":4, "y":1}, | ||
| {"label":"k15", "x":7, "y":1}, | ||
| {"label":"k16", "x":8, "y":1}, | ||
| {"label":"k17", "x":9, "y":1}, | ||
| {"label":"k18", "x":10, "y":1}, | ||
| {"label":"k19", "x":11, "y":1}, | ||
| {"label":"k20", "x":0, "y":2}, | ||
| {"label":"k21", "x":1, "y":2}, | ||
| {"label":"k22", "x":2, "y":2}, | ||
| {"label":"k23", "x":3, "y":2}, | ||
| {"label":"k24", "x":4, "y":2}, | ||
| {"label":"k25", "x":7, "y":2}, | ||
| {"label":"k26", "x":8, "y":2}, | ||
| {"label":"k27", "x":9, "y":2}, | ||
| {"label":"k28", "x":10, "y":2}, | ||
| {"label":"k29", "x":11, "y":2}, | ||
| {"label":"k30", "x":0, "y":3}, | ||
| {"label":"k31", "x":1, "y":3}, | ||
| {"label":"k32", "x":2, "y":3}, | ||
| {"label":"k33", "x":3, "y":3, "w":2}, | ||
| {"label":"k34", "x":5, "y":3, "w":2}, | ||
| {"label":"k35", "x":7, "y":3, "w":2}, | ||
| {"label":"k36", "x":9, "y":3}, | ||
| {"label":"k37", "x":10, "y":3}, | ||
| {"label":"k38", "x":11, "y":3} |
There was a problem hiding this comment.
This will match the updated LAYOUT in rainkeeb.h, but I'm unsure if it's worth reordering the kXY to match the macro elements..
Co-authored-by: ridingqwerty <[email protected]>
ridingqwerty
requested changes
Nov 13, 2020
Co-authored-by: ridingqwerty <[email protected]>
drashna
reviewed
Nov 16, 2020
they all seem to be working perfectly so far, i don't think adding that is neccesary |
github-actions
bot
added
the
via
drashna
approved these changes
Nov 17, 2020
|
Looks good, thanks! |
ridingqwerty
approved these changes
Nov 27, 2020
6 tasks
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
* Add rainkeeb Add support for rainkeeb * gpl license added * updated * Apply suggestions from code review Co-authored-by: ridingqwerty <[email protected]> * Apply suggestions from code review Co-authored-by: ridingqwerty <[email protected]> * Update info.json * via keymap added * updated keymap and .h to work properly * fixed oled code oops Co-authored-by: ridingqwerty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for rainkeeb keyboard.
Description
Adds support for rainkeeb keybord, my first custom design.
Types of Changes
Issues Fixed or Closed by This PR
Checklist