Reverted Dockerfile to put the CMD back #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
mattpcaswell
pushed a commit
to mattpcaswell/qmk_firmware
that referenced
this pull request
Jun 7, 2023
* Added GMK Alter colorway * Fixed issue of short spacebar colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last line of the Dockerfile didn't include a default CMD which most people would rely on when building the image and running it. It had been removed prior, adding it back. An edit to the wiki will follow to include the subproject env variable that was added.
CMD make clean ; make keyboard=${keyboard} subproject=${subproject} keymap=${keymap}%