Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Layouts & Keymaps #10520

Closed
wants to merge 10 commits into from
Closed

Update Layouts & Keymaps #10520

wants to merge 10 commits into from

Conversation

mrsendyyk
Copy link
Contributor

@mrsendyyk mrsendyyk commented Oct 3, 2020 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Oct 3, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure i see the point in some of the changes, it would be nice to see the "why" behind some of them as we can already see the changes via the files changed tab.

keyboards/ai03/soyuz/keymaps/mrsendyyk/keymap.c Outdated Show resolved Hide resolved
keyboards/ai03/soyuz/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ai03/soyuz/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/ai03/soyuz/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/dz60/keymaps/mrsendyyk/keymap.c Outdated Show resolved Hide resolved
layouts/default/60_ansi_arrow/default_60_ansi_arrow/keymap.c Show resolved Hide resolved
@mrsendyyk mrsendyyk changed the title Add ai03 Soyuz and DZ60 Keymaps Update Layouts & Keymaps Oct 3, 2020
@mrsendyyk mrsendyyk closed this Oct 4, 2020
@mrsendyyk mrsendyyk deleted the dev branch October 4, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsendyyk @zvecr