Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename nebula65 -> nebula68 #10490

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Rename nebula65 -> nebula68 #10490

merged 3 commits into from
Oct 1, 2020

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Sep 30, 2020 •
edited
Loading

Last minute rename please. This is about to go into production so the name change will not affect anyone.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc changed the title Rename commit Rename nebula65 -> nebula68 Sep 30, 2020
@tzarc tzarc requested a review from a team September 30, 2020 22:20
@tzarc tzarc added the keyboard label Sep 30, 2020
fauxpark
fauxpark requested changes Oct 1, 2020
View reviewed changes
keyboards/nebula68/config.h Outdated Show resolved Hide resolved
keyboards/nebula68/readme.md Outdated Show resolved Hide resolved
@yiancar
Copy link
Contributor Author

yiancar commented Oct 1, 2020

Cheers!

@fauxpark fauxpark merged commit 76e35e0 into qmk:master Oct 1, 2020
@yiancar yiancar deleted the nebula65-to-68-rename branch October 1, 2020 07:46
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@yiancar @fauxpark @rgoulter
Rename nebula65 -> nebula68 (qmk#10490)
963e843 
Co-authored-by: Ryan <[email protected]>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@yiancar @fauxpark
Rename nebula65 -> nebula68 (qmk#10490)
a1d2871 
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiancar @tzarc @fauxpark