race condition between oneshot_mods and tap_dance #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the keycode for a tap dance process gets process only after the TAPPING_TERM timeout, you really only have ONESHOT_TIMEOUT - TAPPING_TERM time to tap or double tap on the key. This fix save the oneshot_mods into the action.state structure and applies the mods with the keycode when it's registered. It also unregisters the mod when the the tap dance process gets reset.
|
@algernon what do you think? |
|
and thank you @SjB! |
|
I'm trying to wrap my head around this. Gut feeling is that this is a good change, but I don't quite see yet how the race manifests (and I've been a heavy one-shot + tap-dance user, but perhaps I'm too slow to trigger the race). I'll give the PR a go today at work, and report back. |
|
Just tried the PR, and I can't notice any ill side-effects. So |
!
mattpcaswell
pushed a commit
to mattpcaswell/qmk_firmware
that referenced
this pull request
Jun 7, 2023
* First pass moving to VITE - time to put vue-cli out to pasture * Shim the loader into the vite plugin - using https://github.com/SirwanAfifi/vite-plugin-csv/blob/main/src/index.ts as a reference for plugin, shim the loader.js into vite so it can translate the i18n csv files into JS. - re-uses all the excellent work by zekth * Fix keypress listener init * Reduce Bundle Size - extra copies of Vue, still one I haven't gotten rid of - use lazy loading for routes to reduce bundle size * Formatting * Fix lint task * Cypress Fixes - upgrade vue-router to 3.5 - use new isNavigationFailure feature to process errors we don't care about - fix cypress tests - ports have changed with vite - some matchers produce no output now instead of no match - wait before handling typing test because we now init in vuex instead of directly in page prettier * Fix up actions * Fix up env variable prefixes * Attempt to cache Cypress * Fix ajv script so it returns errors to caller * Dangling Comma * Remove stray console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the keycode for a tap dance process gets process only after the
TAPPING_TERM timeout, you really only have ONESHOT_TIMEOUT -
TAPPING_TERM time to tap or double tap on the key. This fix save the
oneshot_mods into the action.state structure and applies the mods with
the keycode when it's registered. It also unregisters the mod when the
the tap dance process gets reset.