Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Mediakeys for yiancar's 328p keyboards #10476

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Enable Mediakeys for yiancar's 328p keyboards #10476

merged 2 commits into from
Oct 1, 2020

Conversation

yiancar
Copy link
Contributor

@yiancar yiancar commented Sep 28, 2020 •
edited
Loading

Now that v-usb is merged please enable my keyboards:)

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added keymap via Adds via keymap and/or updates keyboard for via support labels Sep 28, 2020
@fauxpark fauxpark requested a review from a team October 1, 2020 16:56
@Erovia Erovia merged commit 1960e25 into qmk:master Oct 1, 2020
@yiancar yiancar deleted the barleycorn-gingham-mediakeys branch October 1, 2020 18:11
@zvecr zvecr mentioned this pull request Oct 2, 2020
Merged
14 tasks
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@yiancar @rgoulter
Enable Mediakeys for yiancar's 328p keyboards (qmk#10476)
67490da
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@yiancar
Enable Mediakeys for yiancar's 328p keyboards (qmk#10476)
1fec622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@fauxpark fauxpark fauxpark approved these changes

@Erovia Erovia Erovia approved these changes

Assignees
No one assigned
Labels
keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiancar @Erovia @fauxpark @zvecr