ChibiOS: Decouple USB events from the USB interrupt handler #10437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was triggered on the Djinn prototype -- whenever backlight was enabled with the SPI EEPROM at the same time, bootup of the keyboard would lock up every single time. |
|
Testing requested: suspend handling. |
|
Added some cleanup and initialisation code as well, working fine on both sides of the split. |
tzarc
force-pushed
the
decouple-usb-events
branch
2 times, most recently
from
f2a9692 to
c60e06c
Compare
tzarc
force-pushed
the
decouple-usb-events
branch
from
c60e06c to
e946d82
Compare
tzarc
force-pushed
the
decouple-usb-events
branch
from
e946d82 to
295d2bf
Compare
tzarc
force-pushed
the
decouple-usb-events
branch
from
295d2bf to
de9d810
Compare
tzarc
force-pushed
the
decouple-usb-events
branch
from
de9d810 to
2f8202b
Compare
tzarc
force-pushed
the
decouple-usb-events
branch
from
2f8202b to
0d16562
Compare
drashna
approved these changes
Dec 17, 2020
skullydazed
approved these changes
Jan 31, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Struck a bit of an issue when using backlight and an external EEPROM -- the backlight handler issues a read which can eventually trigger a thread suspension.... the problem is, this is done from within an interrupt handler:
Attempting a thread suspension triggers an unhandled exception and the MCU subsequently locks up.
This PR pushes the event handling to the main keyboard loop.
Types of Changes
Checklist