Added replacement pcb for the matrix cain keyboard #10436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Sep 26, 2020
Co-authored-by: Joel Challis <[email protected]>
fauxpark
requested changes
Sep 27, 2020
Co-authored-by: Ryan <[email protected]>
noroadsleft
requested changes
Sep 28, 2020
There was a problem hiding this comment.
GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.
Also, as this code doesn't support the original Matrix Cain PCB, I'd much prefer if the directory name was something other than cain – something like cain_redux, maybe, though I'm open to suggestions here.
Co-authored-by: James Young <[email protected]>
selected new name as |
noroadsleft
requested changes
Sep 29, 2020
Co-authored-by: James Young <[email protected]>
noroadsleft
approved these changes
Sep 29, 2020
zvecr
approved these changes
Oct 1, 2020
|
Thanks! |
rgoulter
pushed a commit
to rgoulter/qmk_firmware
that referenced
this pull request
Oct 4, 2020
* added replacement pcb for the matrix cain keyboard * update usb descriptor * fixed led polarity * Update keyboards/matrix/cain/cain.c Co-authored-by: Joel Challis <[email protected]> * Update keyboards/matrix/cain/rules.mk Co-authored-by: Ryan <[email protected]> * Apply suggestions from code review Co-authored-by: James Young <[email protected]> * rename from cain to cain_re * Update keyboards/matrix/cain_re/readme.md Co-authored-by: James Young <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: James Young <[email protected]>
kjganz
pushed a commit
to kjganz/qmk_firmware
that referenced
this pull request
Oct 28, 2020
* added replacement pcb for the matrix cain keyboard * update usb descriptor * fixed led polarity * Update keyboards/matrix/cain/cain.c Co-authored-by: Joel Challis <[email protected]> * Update keyboards/matrix/cain/rules.mk Co-authored-by: Ryan <[email protected]> * Apply suggestions from code review Co-authored-by: James Young <[email protected]> * rename from cain to cain_re * Update keyboards/matrix/cain_re/readme.md Co-authored-by: James Young <[email protected]> Co-authored-by: Joel Challis <[email protected]> Co-authored-by: Ryan <[email protected]> Co-authored-by: James Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added replacement pcb for the matrix cain keyboard
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist