Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SiCK-PAD Keyboard #10429

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Add SiCK-PAD Keyboard #10429

merged 6 commits into from
Sep 29, 2020

Conversation

jmschneider
Copy link
Contributor

Add SiCK-PAD Keyboard

Add a keyboad config for the SiCK-PAD handwired numpad

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some older conventions in use here.

If you commit my suggestions and rename the kb.{c,h} files to sick_pad.{c,h}, you should be good to go.

keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/kb.c Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/kb.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/kb.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@jmschneider
Copy link
Contributor Author

Thank you for the guidance @ridingqwerty, I am new to working with QMK. I think I've got every thing set now. Let me know if there are any other blockers.

Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

keyboards/handwired/sick_pad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/sick_pad.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/rules.mk Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team September 26, 2020 23:13
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/handwired/sick_pad/config.h Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/config.h Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/sick_pad/sick_pad.c Show resolved Hide resolved
keyboards/handwired/sick_pad/sick_pad.h Show resolved Hide resolved
@noroadsleft noroadsleft merged commit 2eeb30c into qmk:master Sep 29, 2020
@noroadsleft
Copy link
Member

Thanks!

tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 1, 2020
* Add sick_pad

* Adjust setup for Proton C

* Add readme

* Add info.json

* Make requested changes

* Resolve PR issues
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
* Add sick_pad

* Adjust setup for Proton C

* Add readme

* Add info.json

* Make requested changes

* Resolve PR issues
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* Add sick_pad

* Adjust setup for Proton C

* Add readme

* Add info.json

* Make requested changes

* Resolve PR issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants