Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Bolsa65 Keyboard #10394

Merged
merged 31 commits into from
Sep 24, 2020
Merged

Added Bolsa65 Keyboard #10394

merged 31 commits into from
Sep 24, 2020

Conversation

mrnoisytiger
Copy link
Contributor

Description

Added the Bolsa65 Keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mrnoisytiger mrnoisytiger mentioned this pull request Sep 22, 2020
Merged
6 tasks
drashna
drashna requested changes Sep 22, 2020
View reviewed changes
keyboards/fjlabs/bolsa65/bolsa65.c Outdated Show resolved Hide resolved
keyboards/fjlabs/bolsa65/config.h Outdated Show resolved Hide resolved
keyboards/fjlabs/bolsa65/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/fjlabs/bolsa65/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 22, 2020 05:07
@drashna drashna added keyboard via Adds via keymap and/or updates keyboard for via support labels Sep 22, 2020
drashna
drashna requested changes Sep 22, 2020
View reviewed changes
keyboards/fjlabs/bolsa65/config.h Outdated Show resolved Hide resolved
mrnoisytiger and others added 5 commits September 22, 2020 00:08
@mrnoisytiger @drashna
Update keyboards/fjlabs/bolsa65/bolsa65.c
9b4bb89 
Fixed indentation as suggested.

Co-authored-by: Drashna Jaelre <[email protected]>
@mrnoisytiger @drashna
Update keyboards/fjlabs/bolsa65/config.h
607882f 
Removed extraneous defaults

Co-authored-by: Drashna Jaelre <[email protected]>
@mrnoisytiger @drashna
Update keyboards/fjlabs/bolsa65/keymaps/default/keymap.c
5836991 
Different layer enumeration method

Co-authored-by: Drashna Jaelre <[email protected]>
@mrnoisytiger @drashna
Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c
325aa02 
New layer enumeration method.

Co-authored-by: Drashna Jaelre <[email protected]>
@mrnoisytiger @drashna
Update keyboards/fjlabs/bolsa65/config.h
0ab9445 
Removed extraneous description.

Co-authored-by: Drashna Jaelre <[email protected]>
@drashna drashna requested a review from a team September 22, 2020 05:29
fauxpark
fauxpark requested changes Sep 22, 2020
View reviewed changes
keyboards/fjlabs/bolsa65/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/fjlabs/bolsa65/readme.md Outdated Show resolved Hide resolved
keyboards/fjlabs/bolsa65/rules.mk Outdated Show resolved Hide resolved
mrnoisytiger and others added 3 commits September 22, 2020 09:25
@mrnoisytiger @fauxpark
Update keyboards/fjlabs/bolsa65/keymaps/via/rules.mk
e6e0c71 
Removed extraneous bootmagic

Co-authored-by: Ryan <[email protected]>
@mrnoisytiger @fauxpark
Update keyboards/fjlabs/bolsa65/rules.mk
253d383 
Updated rules

Co-authored-by: Ryan <[email protected]>
@mrnoisytiger @fauxpark
Update keyboards/fjlabs/bolsa65/readme.md
6ad757a 
Markdown list formatting

Co-authored-by: Ryan <[email protected]>
@mrnoisytiger
Copy link
Contributor Author

Requested changed made.

@zvecr
Copy link
Member

zvecr commented Sep 23, 2020

Just need confirmation on the layout question within #10394 (review)

@mrnoisytiger
Copy link
Contributor Author

@zvecr There are no additional layouts for this PCB. Thanks!

noroadsleft
noroadsleft requested changes Sep 24, 2020
View reviewed changes
keyboards/fjlabs/bolsa65/info.json Outdated Show resolved Hide resolved
keyboards/fjlabs/bolsa65/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@mrnoisytiger
Copy link
Contributor Author

Requested changes made. 😊

@noroadsleft noroadsleft merged commit 4511201 into qmk:master Sep 24, 2020
@noroadsleft
Copy link
Member

Thanks!

tomohisa pushed a commit to tomohisa/qmk_firmware that referenced this pull request Sep 28, 2020
Merge branch 'master' of https://github.com/qmk/qmk_firmware
8c2197d 
* 'master' of https://github.com/qmk/qmk_firmware: (3643 commits)
  Swapparoo of bottom row keys (qmk#10277)
  [Keyboard] Add PloopyCo devices (qmk#7935)
  Keyboard update: SL40 (qmk#10445)
  [keyboard] Add SP-111 support (qmk#10193)
  Add logic for AT90USBxx7 where needed (qmk#10203)
  Trifecta Keymap
  [Docs] Wording & formatting changes in the Tapping Force Hold section of the Tap Hold page + removed trailing whitespaces (qmk#10391)
  `setrgb()`: Use arrow operator (qmk#10451)
  [Keyboard] add Percent Canoe Gen2 (qmk#10344)
  [Keyboard] add hannah65 by Team Mechlovin (qmk#10284)
  Fix Belgian sendstring properly (qmk#10444)
  Add VIA support for lazydesigners/the30 (qmk#10374)
  [Keyboard] add duckboard by doodboard (qmk#10318)
  Fix Belgian sendstring file (qmk#10443)
  [Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394)
  CLI/Doctor: Print QMK_HOME (qmk#10398)
  Add Wyvern Keyboard (qmk#10378)
  Adding Bear 65 Ergo Keyboard To QMK (qmk#10384)
  VIA Support: Gray Studio HB85 (qmk#10329)
  format code according to conventions [skip ci]
  ...
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@mrnoisytiger @rgoulter
[Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394)
a7cb05d 
* Modifed for BKS65

* Added test board

* attempts

* Working compile

* updated rules for processor frequency and documented

* Disabed some deprecated features

* Removed extraneous code

* remove test code

* Renamed board

* LED and layer code

* Added via support

* Update keyboards/fjlabs/bolsa65/bolsa65.c

Fixed indentation as suggested.

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous defaults

* Update keyboards/fjlabs/bolsa65/keymaps/default/keymap.c

Different layer enumeration method

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

New layer enumeration method.

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous description.

* Update keyboards/fjlabs/bolsa65/keymaps/via/rules.mk

Removed extraneous bootmagic

* Update keyboards/fjlabs/bolsa65/rules.mk

Updated rules

* Update keyboards/fjlabs/bolsa65/readme.md

Markdown list formatting

* Update keyboards/fjlabs/bolsa65/bolsa65.h

Changed layout name

* Update keyboards/fjlabs/bolsa65/info.json

Changed layout name

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

Changed Layout name

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

Change layout name

* Changed layout names

* Updated readme to reflect new keyboard name

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous code

* Added license file header

* Removed VSCode folder

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

* Update keyboards/fjlabs/bolsa65/info.json

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@mrnoisytiger
[Keyboard] added Bolsa65 keyboard by FJLabs (qmk#10394)
cb4a5ed 
* Modifed for BKS65

* Added test board

* attempts

* Working compile

* updated rules for processor frequency and documented

* Disabed some deprecated features

* Removed extraneous code

* remove test code

* Renamed board

* LED and layer code

* Added via support

* Update keyboards/fjlabs/bolsa65/bolsa65.c

Fixed indentation as suggested.

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous defaults

* Update keyboards/fjlabs/bolsa65/keymaps/default/keymap.c

Different layer enumeration method

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

New layer enumeration method.

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous description.

* Update keyboards/fjlabs/bolsa65/keymaps/via/rules.mk

Removed extraneous bootmagic

* Update keyboards/fjlabs/bolsa65/rules.mk

Updated rules

* Update keyboards/fjlabs/bolsa65/readme.md

Markdown list formatting

* Update keyboards/fjlabs/bolsa65/bolsa65.h

Changed layout name

* Update keyboards/fjlabs/bolsa65/info.json

Changed layout name

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

Changed Layout name

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

Change layout name

* Changed layout names

* Updated readme to reflect new keyboard name

* Update keyboards/fjlabs/bolsa65/config.h

Removed extraneous code

* Added license file header

* Removed VSCode folder

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c

* Update keyboards/fjlabs/bolsa65/info.json

* Update keyboards/fjlabs/bolsa65/keymaps/via/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrnoisytiger @zvecr @noroadsleft @drashna @fauxpark