Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Slice VIA Support #10385

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Add Slice VIA Support #10385

merged 3 commits into from
Sep 22, 2020

Conversation

2Moons-JP
Copy link
Contributor

Add Slice Via support

Description

Addition of Slice Via support. The Slice RGB version will be added at a later date.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team September 22, 2020 04:50
@drashna drashna added keyboard via Adds via keymap and/or updates keyboard for via support labels Sep 22, 2020
@2Moons-JP 2Moons-JP requested review from drashna and removed request for a team September 22, 2020 06:37
@noroadsleft noroadsleft merged commit e52fc93 into qmk:master Sep 22, 2020
@noroadsleft
Copy link
Member

Thanks!

@2Moons-JP 2Moons-JP mentioned this pull request Sep 23, 2020
Closed
6 tasks
@2Moons-JP 2Moons-JP mentioned this pull request Sep 24, 2020
Merged
6 tasks
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@2Moons-JP @rgoulter
Add VIA Support for Basekeys Slice rev1 (qmk#10385)
f435482 
* Slice Via

* Keymap Update

* Update keyboards/basekeys/slice/rev1/keymaps/via/keymap.c
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@2Moons-JP
Add VIA Support for Basekeys Slice rev1 (qmk#10385)
089c79b 
* Slice Via

* Keymap Update

* Update keyboards/basekeys/slice/rev1/keymaps/via/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna Awaiting requested review from drashna

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2Moons-JP @noroadsleft @drashna @fauxpark