Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trifecta Keyboard #10375

Merged
merged 14 commits into from
Sep 24, 2020
Merged

Trifecta Keyboard #10375

merged 14 commits into from
Sep 24, 2020

Conversation

2Moons-JP
Copy link
Contributor

Trifecta Keyboard

Description

An Alice style board with arrow keys. Aluminum and Polycarb versions with options for various top plates.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Sep 21, 2020
View reviewed changes
keyboards/basekeys/trifecta/config.h Show resolved Hide resolved
keyboards/basekeys/trifecta/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 21, 2020 03:59
@2Moons-JP 2Moons-JP requested review from drashna and removed request for a team September 21, 2020 04:40
@drashna drashna requested a review from a team September 21, 2020 04:49
fauxpark
fauxpark requested changes Sep 21, 2020
View reviewed changes
keyboards/basekeys/trifecta/config.h Outdated Show resolved Hide resolved
keyboards/basekeys/trifecta/config.h Outdated Show resolved Hide resolved
keyboards/basekeys/trifecta/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/basekeys/trifecta/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/basekeys/trifecta/rules.mk Outdated Show resolved Hide resolved
keyboards/basekeys/trifecta/rules.mk Outdated Show resolved Hide resolved
@2Moons-JP 2Moons-JP requested a review from fauxpark September 21, 2020 09:22
noroadsleft
noroadsleft requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you have Tap Dance enabled for both keymaps, but then the key assignment don't use the Tap Dance keycodes at all. You could remove the Tap Dance code and not turn the feature on, and it would save a bit of space.

keyboards/basekeys/trifecta/readme.md Outdated Show resolved Hide resolved
keyboards/basekeys/trifecta/readme.md Outdated Show resolved Hide resolved
@2Moons-JP
Copy link
Contributor Author

Also, you have Tap Dance enabled for both keymaps, but then the key assignment don't use the Tap Dance keycodes at all. You could remove the Tap Dance code and not turn the feature on, and it would save a bit of space.

I commited these changes. Thank you.

@2Moons-JP 2Moons-JP requested a review from fauxpark September 23, 2020 00:27
@2Moons-JP 2Moons-JP mentioned this pull request Sep 23, 2020
Merged
6 tasks
@noroadsleft noroadsleft merged commit 940c294 into qmk:master Sep 24, 2020
@noroadsleft
Copy link
Member

Thanks!

rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@2Moons-JP @rgoulter
[Keyboard] add Basekeys Trifecta (qmk#10375)
6b6a6c5 
* Trifecta 09-20

* Update keyboards/basekeys/trifecta/config.h

* Update keyboards/basekeys/trifecta/config.h

* Update keyboards/basekeys/trifecta/config.h

* Update keyboards/basekeys/trifecta/keymaps/default/keymap.c

* Update keyboards/basekeys/trifecta/keymaps/via/keymap.c

* Update keyboards/basekeys/trifecta/rules.mk

* Update rules.mk

Suggested Changes

* Update keyboards/basekeys/trifecta/readme.md

* Update keyboards/basekeys/trifecta/readme.md

* Tap Dance Removal

* Update keyboards/basekeys/trifecta/keymaps/default/keymap.c

* Update keyboards/basekeys/trifecta/keymaps/default/keymap.c

* Update keyboards/basekeys/trifecta/keymaps/via/keymap.c
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@2Moons-JP
[Keyboard] add Basekeys Trifecta (qmk#10375)
dfc01c7 
* Trifecta 09-20

* Update keyboards/basekeys/trifecta/config.h

* Update keyboards/basekeys/trifecta/config.h

* Update keyboards/basekeys/trifecta/config.h

* Update keyboards/basekeys/trifecta/keymaps/default/keymap.c

* Update keyboards/basekeys/trifecta/keymaps/via/keymap.c

* Update keyboards/basekeys/trifecta/rules.mk

* Update rules.mk

Suggested Changes

* Update keyboards/basekeys/trifecta/readme.md

* Update keyboards/basekeys/trifecta/readme.md

* Tap Dance Removal

* Update keyboards/basekeys/trifecta/keymaps/default/keymap.c

* Update keyboards/basekeys/trifecta/keymaps/default/keymap.c

* Update keyboards/basekeys/trifecta/keymaps/via/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2Moons-JP @noroadsleft @drashna @fauxpark