Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Handwired/Curiosity [Keyboard Addition] #10369

Merged
merged 7 commits into from
Sep 22, 2020
Merged

Add Handwired/Curiosity [Keyboard Addition] #10369

merged 7 commits into from
Sep 22, 2020

Conversation

LostQuasar
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Sep 20, 2020
View reviewed changes
keyboards/handwired/curiosity/curiosity.h Outdated Show resolved Hide resolved
keyboards/handwired/curiosity/curiosity.h Outdated Show resolved Hide resolved
keyboards/handwired/curiosity/info.json Outdated Show resolved Hide resolved
keyboards/handwired/curiosity/info.json Outdated Show resolved Hide resolved
keyboards/handwired/curiosity/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/curiosity/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 20, 2020 01:48
fauxpark
fauxpark requested changes Sep 20, 2020
View reviewed changes
keyboards/handwired/curiosity/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/curiosity/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/curiosity/rules.mk Outdated Show resolved Hide resolved
@noroadsleft noroadsleft merged commit 207f0b0 into qmk:master Sep 22, 2020
@noroadsleft
Copy link
Member

Thanks!

rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@LostQuasar @rgoulter
[Keyboard] add Handwired/Curiosity (qmk#10369)
0734b2c 
* Add curiosity

* Add default keymap

* Update config.h

* Apply suggestions from code review

* Update keyboards/handwired/curiosity/rules.mk

* Update keymap.c

* Apply suggestions from code review
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@LostQuasar
[Keyboard] add Handwired/Curiosity (qmk#10369)
2bf36e5 
* Add curiosity

* Add default keymap

* Update config.h

* Apply suggestions from code review

* Update keyboards/handwired/curiosity/rules.mk

* Update keymap.c

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LostQuasar @noroadsleft @drashna @fauxpark