Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA support for YD60MQ #10321

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Add VIA support for YD60MQ #10321

merged 4 commits into from
Sep 22, 2020

Conversation

rbange
Copy link
Contributor

@rbange rbange commented Sep 15, 2020 •
edited
Loading

Description

This PR adds VIA support for the YD60MQ board, as last PR #10273 has been dropped.

VIA-PR: the-via/keyboards#309

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@rbange rbange mentioned this pull request Sep 15, 2020
Merged
6 tasks
@drashna drashna added keyboard via Adds via keymap and/or updates keyboard for via support labels Sep 21, 2020
@drashna drashna requested a review from a team September 21, 2020 00:06
fauxpark
fauxpark approved these changes Sep 21, 2020
View reviewed changes
keyboards/yd60mq/config.h Outdated Show resolved Hide resolved
@rbange rbange requested a review from fauxpark September 21, 2020 10:18
@rbange rbange requested a review from noroadsleft September 22, 2020 09:27
@noroadsleft noroadsleft merged commit 1ff5157 into qmk:master Sep 22, 2020
@noroadsleft
Copy link
Member

Thanks!

@rbange rbange deleted the via_yd60mq branch September 23, 2020 09:04
@rbange rbange mentioned this pull request Sep 23, 2020
Open
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@rbange @rgoulter
Add VIA support for YD60MQ (qmk#10321)
1993b0c 
* add via support for yd60mq

* switch to bootmagic lite, to decrease firmware size

* Update PRODUCT_ID comment

* add license header
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@rbange
Add VIA support for YD60MQ (qmk#10321)
a2a9c8f 
* add via support for yd60mq

* switch to bootmagic lite, to decrease firmware size

* Update PRODUCT_ID comment

* add license header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbange @noroadsleft @drashna @fauxpark