Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Corin Keyboard #10280

Merged
merged 11 commits into from
Sep 22, 2020
Merged

[Keyboard] Add Corin Keyboard #10280

merged 11 commits into from
Sep 22, 2020

Conversation

seatonjiang
Copy link
Contributor

@seatonjiang seatonjiang commented Sep 10, 2020

Description

Corin is a 64-key keyboard that adds 4 more arrow keys than a regular 60% keyboard, and has Home and End buttons next to the arrow keys.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/longnald/corin/rules.mk Outdated Show resolved Hide resolved
keyboards/longnald/corin/config.h Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 21, 2020 01:01
@seatonjiang seatonjiang requested review from drashna and removed request for a team September 21, 2020 01:43
keyboards/longnald/corin/config.h Outdated Show resolved Hide resolved
keyboards/longnald/corin/info.json Outdated Show resolved Hide resolved
keyboards/longnald/corin/readme.md Outdated Show resolved Hide resolved
keyboards/longnald/corin/readme.md Outdated Show resolved Hide resolved
keyboards/longnald/corin/rules.mk Outdated Show resolved Hide resolved
keyboards/longnald/corin/rules.mk Outdated Show resolved Hide resolved
@seatonjiang
Copy link
Contributor Author

@drashna @fauxpark Thanks for the correction, the above question has been corrected.

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renames the layout macro to LAYOUT_64_ansi, which opens up the possibility of turning this into a Community Layout. (There are some other keyboards that support this layout.)

keyboards/longnald/corin/info.json Outdated Show resolved Hide resolved
keyboards/longnald/corin/corin.h Outdated Show resolved Hide resolved
keyboards/longnald/corin/info.json Outdated Show resolved Hide resolved
keyboards/longnald/corin/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/longnald/corin/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/longnald/corin/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/longnald/corin/keymaps/default/keymap.c Outdated Show resolved Hide resolved
seatonjiang and others added 7 commits September 22, 2020 14:44
@noroadsleft noroadsleft merged commit e3395be into qmk:master Sep 22, 2020
@noroadsleft
Copy link
Member

noroadsleft commented Sep 22, 2020

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

Fixing Your Branch will walk you through fixing up your master branch moving forward. If you need any help with this just ask.

Thanks for contributing!

rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
* [Keyboard] Add Longnald Corin

* feat: optimized firmware

* feat: optimized firmware

* fix: keyboards/longnald/corin/rules.mk

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
* [Keyboard] Add Longnald Corin

* feat: optimized firmware

* feat: optimized firmware

* fix: keyboards/longnald/corin/rules.mk

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros

* feat: rename layout macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants