-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new qmk subcommand for creating compile_commands.json
for better clangd/IDE interop
#10264
Conversation
compile_commands.json
for better clangd/IDE interop
two questions. I think I've asked this before, actually ...
|
|
(also to be clear, I'm not using clang to build qmk. this is strictly used by my dev environment to help intellisense) |
Okay, sounds good then. I just wanted to make sure. |
Just some quick feedback: This seems to work well for me, and I'd like to see this merged into master. |
Co-authored-by: Michael Forster <[email protected]>
committed suggestion. |
lgtm |
Usage line added. Anything else? ptal @skullydazed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor docs change, otherwise LGTM.
Co-authored-by: Nick Brassel <[email protected]>
Apologies for not getting back to this sooner. Overall this looks good but I wasn't able to come up with a name that worked better. Normally I'd have merged it anyway but 2020 has changed a lot of routines, and I hadn't cycled around to reviews again in a while. In the meantime a lot of our current and future work has coalesced around a naming pattern for this sort of this. Could you make one last change to fit this scheme? Calling it |
Thank you for your contribution! |
Thank you for your contribution! |
Was there anything else blocking this PR, aside from deciding on the name of the target? I'd also love to see this feature merged in! |
Description
(I'm not able to re-open #8916, so I'm filing a new PR)
I use clangd as a languageserver along with coc.vim[0]. It requires a compilation database[1] to help it figure out how to find all the required files for a given compilation pass. This PR adds a new subcommand (
compiledb
) which creates that for you. Now your dev environment can figure out what#include QMK_KEYBOARD_H
means.[0] https://github.com/neoclide/coc.nvim/wiki/Language-servers#ccobjective-c
[1] https://clang.llvm.org/docs/JSONCompilationDatabase.html
Types of Changes
Issues Fixed or Closed by This PR
Checklist