Adding support for the Katana60revision2 PCB #10229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update readme.md
splitting folder structure to support new revisions and adding new config for new pcb layout
As it turns out the katana60rev2 pcb has different column/row key assignments in comparison to rev1
Reverted removal of newlines in original file and removed two empty makefiles because they are not needed
During final testing i noticed that each revision folder needs a makefile even if it is empty
|
Hey, thank you for taking the time to put this together. The revision 2 model supports slightly different bottom rows, so I'm not sure if it's possible to limit Katana60 to a single project folder in qmk (certainly not with my knowledge of it). I am preparing a pull request for a katana60rev2 keyboard folder. |
|
I created a new pull request with the updated firmware and a couple of layouts, you can find it here: #10255 |
alrigth, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently @rominronin's Katana60rev2 PCB is sold but there is no QMK support yet.
In order to support the new revisions base layout it was required to change the pin assignement of the microcontroller to the key matrix and the diode direction.
To do this i serperated the current folder structure into two subfolders for each revision.
While doing this i tried to modify as little existing config files and code as possible.
I tested the resulting binary with the original Katana60rev2 PCB.
Types of Changes
Issues Fixed or Closed by This PR
Checklist