-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ChibiOS backlight not turning off on suspend #10114
Conversation
Will need to be rebased onto |
This is a bugfix, I think it should go into master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight __attribute__ ((weak))
✔️ because I don't have any ChibiOS boards with backlighting.
did we want to import the rest of the code too? Eg, this: qmk_firmware/tmk_core/common/avr/suspend.c Lines 92 to 100 in 8937c14
Note, there doesn't seem to be any wake code (as it wouldn't actually be needed). |
@drashna done |
LGTM, ship it. |
Thanks! |
* Fix ChibiOS backlight not turning off on suspend * Add missing code for backlight as caps lock too
* Fix ChibiOS backlight not turning off on suspend * Add missing code for backlight as caps lock too
* Fix ChibiOS backlight not turning off on suspend * Add missing code for backlight as caps lock too
* Fix ChibiOS backlight not turning off on suspend * Add missing code for backlight as caps lock too
Description
This is present in the AVR suspend code, but missing here.
Types of Changes
Issues Fixed or Closed by This PR
Checklist