Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Super16 VIA support #10076

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Super16 VIA support #10076

merged 1 commit into from
Aug 18, 2020

Conversation

nblyumberg
Copy link
Contributor

Added VIA support for 1upkeyboards Super16

Description

Added the VIA keymap following the documentation. Tested with the VIA design tab.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team August 18, 2020 04:32
@fauxpark fauxpark added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 18, 2020
@nblyumberg nblyumberg mentioned this pull request Aug 18, 2020
Merged
6 tasks
@nblyumberg nblyumberg changed the title Super16 via Super16 VIA Support Aug 18, 2020
@nblyumberg nblyumberg changed the title Super16 VIA Support Super16 VIA support Aug 18, 2020
noroadsleft
noroadsleft approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually like these to match the default keymap, but I like this one better than the default, so 🚀

@noroadsleft noroadsleft merged commit 0e542b2 into qmk:master Aug 18, 2020
@noroadsleft
Copy link
Member

Thanks!

@nblyumberg nblyumberg deleted the Super16_via branch August 19, 2020 15:55
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@nblyumberg @nicocesar
Super16 VIA support (qmk#10076)
331eeb1 
* Added via support for Super16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nblyumberg @noroadsleft @fauxpark